feat: add ExtraParams support for declaring path params not in input models#2
Closed
feat: add ExtraParams support for declaring path params not in input models#2
Conversation
…models Add support for declaring extra path parameters at the operation level. This is useful when path parameters come from parent routes (e.g., /v1/:contract_id/...) and are not defined in handler input models. - Add ExtraParams field to OperationInfo - Add ExtraParam struct for parameter metadata - Add PathParam and QueryParam OperationOption functions - Update generator to include extra params before validation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
Closing this PR - we found a workaround by embedding BasePathParams in input structs, which allows fizz to find path params via reflection without requiring library changes. This enables releasing stacster as OSS without needing to merge fizz changes first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExtraParamsfield toOperationInfofor declaring additional path/query parametersExtraParamstruct for parameter metadataPathParam()andQueryParam()OperationOption functionsBackground
This enables declaring path parameters at the operation level when they come from parent routes (e.g.,
/v1/:contract_id/...) and are not defined in handler input models.Without this, fizz's OpenAPI validation fails with:
Usage
Test plan
🤖 Generated with Claude Code