Being able to "stick" a page on a previous-view monitor#8
Open
egueli wants to merge 8 commits intoSankore:masterfrom
Open
Being able to "stick" a page on a previous-view monitor#8egueli wants to merge 8 commits intoSankore:masterfrom
egueli wants to merge 8 commits intoSankore:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows the teacher to choose which page to use as a base for previous views.
In a multi-monitor Open-Sankoré environment, additional monitors will show the pages preceding the one the teacher is currently using (i.e. "previous views"). When only one additional monitor is available, it will show the previous page, and if the teacher wants to show another page, he's forced to change his current page too. This patch allows the teacher to explicitly choose, or "stick", a page as the one to show in the additional monitor, regardless of which page the teacher is working on. If more additional monitors are available, they will show the pages preceding the stuck one.
This patch adds a button in the page thumbnail widget, that will appear among the others (duplicate, delete, move up, move down) when the mouse hovers a thumbnail. The button has the icon of an external monitor, as used elsewhere in the app. By clicking on this button, the first additional monitor will show that page. The button remains visible even when the mouse is elsewhere, in order to inform the teacher that the previous views are stuck on that page. Sticking another page will un-stick the old page and stick the new one. "Re-sticking" the same page will disable sticking and the additional monitors will behave as before, i.e. showing the previous pages.