Recover some missing includes and defines#7
Open
Ascaf0 wants to merge 4 commits intoSankore:masterfrom
Open
Conversation
Recover missing #includes
remove space I added unintentionally
Recover missing #includes
Recover missing includes and defines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While compiling (for openSUSE) from Sankore-3.1 master some errors came out, it appears due to some missing includes and defines. By comparing last commit (Jan 31, 2013 - fixed licence to gpl3) with the previous commit, some of them (hopefully all of them) got recovered (is it possible they got missing while updating license header during Jan 31, 2013 commit?).
Anyway, now sources appear to compile again (with openSUSE, at least)... in brief decided might be the case to issue a pull request: hope these infos are not (too) redundant for the devs and that might be of some usefulness, in some way.
Regards and of course infinite thanks for this wonderful tool.