Enable OFI provider for Slingshot#1059
Merged
wrrobin merged 11 commits intoSandia-OpenSHMEM:mainfrom Feb 13, 2023
Merged
Conversation
added 5 commits
August 4, 2022 14:39
Signed-off-by: Md Rahman <md.rahman@intel.com>
davidozog
reviewed
Sep 28, 2022
jdinan
reviewed
Feb 7, 2023
… ifdef for mr_endpoint
jdinan
reviewed
Feb 8, 2023
Collaborator
Author
|
@davidozog This is ready for a re-review. Thanks. |
davidozog
reviewed
Feb 9, 2023
Member
davidozog
left a comment
davidozog
left a comment
There was a problem hiding this comment.
I tested the changes and it's looking good ;)
I just have a naming suggestion and a concern about the NBI fetching AMO.
davidozog
reviewed
Feb 10, 2023
Member
davidozog
left a comment
davidozog
left a comment
There was a problem hiding this comment.
I think we're ready to merge this - just one more question...
davidozog
approved these changes
Feb 11, 2023
Collaborator
Author
|
@kholland-intel Could you try this PR on your end and see if everything looks ok? Need a review from your side as well. |
kholland-intel
approved these changes
Feb 13, 2023
Collaborator
kholland-intel
left a comment
kholland-intel
left a comment
There was a problem hiding this comment.
I have just tested the latest changes and everything passes for me. The code looks good too. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Md Rahman md.rahman@intel.com