Fix handling of out-of-order packets during login sequence#389
Open
EinBexiii wants to merge 2 commits intoSandertv:masterfrom
Open
Fix handling of out-of-order packets during login sequence#389EinBexiii wants to merge 2 commits intoSandertv:masterfrom
EinBexiii wants to merge 2 commits intoSandertv:masterfrom
Conversation
Packets may arrive out of order due to network conditions. Previously, packets that arrived before they were expected would be deferred but never processed if they arrived before the expected packet IDs were updated. This adds processDeferredPackets() which checks if any deferred packets match the currently expected IDs and handles them immediately. It is called after each expect() during the login sequence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packets may arrive out of order due to network conditions. Previously,
packets that arrived before they were expected would be deferred but
never processed if they arrived before the expected packet IDs were
updated.
This adds processDeferredPackets() which checks if any deferred packets
match the currently expected IDs and handles them immediately. It is
called after each expect() during the login sequence.
Fixes connection issues with servers like play.lbsg.net.