Refactor resource pack loading to avoid writing temp files#286
Open
GameParrot wants to merge 1 commit intoSandertv:masterfrom
Open
Refactor resource pack loading to avoid writing temp files#286GameParrot wants to merge 1 commit intoSandertv:masterfrom
GameParrot wants to merge 1 commit intoSandertv:masterfrom
Conversation
Contributor
GameParrot
commented
Feb 19, 2025
GameParrot
commented
- Loading resource packs from urls or readers no longer writes a temp file to disk
- Added resource.ReadBytes() and resource.MustReadBytes(), mainly intended for resource pack data embedded with go:embed
- Download URLs are now used to download packs from servers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.