Fix screen recording permission detection and add app icon #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also made sure the Application's Icon was included in the build process. |
Contributor
Author
|
Here is the new version of the app to test: ScreenScribe.app.zip |
There was a problem hiding this comment.
Pull request overview
This pull request aims to fix screen recording permission detection issues on macOS Sequoia by implementing a more robust retry mechanism with longer delays and adding a fallback permission check method.
Changes:
- Increased retry attempts from 3 to 5 with longer delays (1.0s base instead of 0.5s) and linear backoff
- Added CGPreflightScreenCaptureAccess as a fallback check before showing the system permission dialog
- Added a "Recheck Permission" button in the onboarding UI for manual permission re-verification
- Included unrelated additions: app icon assets and .gitignore entries for agent directories
Reviewed changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| ScreenScribe/Sources/Services/ScreenCapturePermissionManager.swift | Enhanced permission detection with increased retry attempts, longer delays, improved error logging, and fallback permission check |
| ScreenScribe/Sources/Onboarding/PermissionStepView.swift | Added "Recheck Permission" button to allow users to manually trigger permission verification |
| ScreenScribe/Assets.xcassets/Contents.json | Added asset catalog configuration (unrelated to permission fix) |
| ScreenScribe/Assets.xcassets/AppIcon.appiconset/Icon_512.png | Added app icon image (unrelated to permission fix) |
| ScreenScribe/Assets.xcassets/AppIcon.appiconset/Contents.json | Added app icon set configuration (unrelated to permission fix) |
| ScreenScribe.xcodeproj/project.pbxproj | Updated project configuration to include new assets and reordered build phase entries |
| .gitignore | Added agent-related directories (unrelated to permission fix) |
| .github/workflows/claude.yml | Removed trailing whitespace (formatting cleanup) |
| .github/workflows/claude-code-review.yml | Removed trailing whitespace (formatting cleanup) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ScreenScribe/Sources/Services/ScreenCapturePermissionManager.swift
Outdated
Show resolved
Hide resolved
ScreenScribe/Sources/Services/ScreenCapturePermissionManager.swift
Outdated
Show resolved
Hide resolved
rapjul
changed the title
…tion - Change "exponential backoff" to "linear backoff" in comments (3 locations) - Clarify error handling comments to avoid misleading claims about error codes - Add isCheckingPermission state to prevent concurrent permission checks These changes address Copilot review feedback on PR SamuelZ12#10.
…tions - Add 30-second cooldown between system permission dialog attempts - Add 6-step troubleshooting guide to PermissionStepView - Improve UX when permission detection is flaky on macOS Sequoia
…ts, and bug fixes" This reverts commit b0d915c.
SamuelZ12
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the app working on my laptop that is running macOS Sequoia.
Hopefully this helps. Thank you for developing this great app!