Skip to content

Conversation

@kevinearldenny
Copy link

@kevinearldenny kevinearldenny commented Jan 21, 2021

Critical Changes

  • Fix a data loss currently occurring for Cicero customers when entering unit numbers in street address for address validation like "3018 Ellwood Ave, 2"

Changes

  • Split out address components after a comma, and add them back in to MailingStreet__c instead of allowing them to get overwritten by the result of match_addr

Issues Closed

#6199

Community Ideas Delivered

Fix an issue encountered by Cicero customers using the NPSP integration where unit numbers are removed when a user enters them as part of Mailing address line 1, i.e. "3018 Ellwood Ave, 2".

Current state

  • API response returns match_addr as "3018 Ellwood Ave"
  • Unit number is stripped from MailingStreet__c, which is updated to be "3018 Ellwood Ave"

Expected

  • API response returns match_addr as "3018 Ellwood Ave"
  • MailingStreet__c is set to "3018 Ellwood Ave, 2"

New Metadata

N/A

Deleted Metadata

N/A

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @kevinearldenny to sign the Salesforce.com Contributor License Agreement.

@coriobriensfdo
Copy link

Thank you for the contribution @kevinearldenny! I've alerted the NPSP team so that someone can do a review.

W-8777462

@kevinearldenny
Copy link
Author

Hi @coriobriensfdo - this is still a WIP. Folks from the Cicero team will be reaching out via email with further comms around resolving this issue.

Thanks!
Kevin

@coriobriensfdo
Copy link

Hi @coriobriensfdo - this is still a WIP. Folks from the Cicero team will be reaching out via email with further comms around resolving this issue.

Thanks!
Kevin

@kevinearldenny ok I'll let the team know to hold off for now. Regarding the Cicero team, do you mean they're going to be working with you and your team? It might help if you filed an Issue related to this PR so that you can fully explain the issue if it's within the NPSP code.

@kevinearldenny kevinearldenny force-pushed the feature/ked/fix-two-line-addresses-cicero branch 2 times, most recently from f149142 to 848a91c Compare January 25, 2021 16:02
@kevinearldenny kevinearldenny changed the title Split apartment numbers into second line of mailing address Preserve secondary address components after comma entered in MailingStreet Jan 25, 2021
@kevinearldenny kevinearldenny force-pushed the feature/ked/fix-two-line-addresses-cicero branch from 16589ea to d7c0235 Compare January 25, 2021 16:29
@kevinearldenny kevinearldenny force-pushed the feature/ked/fix-two-line-addresses-cicero branch from d7c0235 to 1d271aa Compare January 25, 2021 16:58
@kevinearldenny kevinearldenny marked this pull request as ready for review January 25, 2021 17:27
@kevinearldenny
Copy link
Author

@coriobriensfdo This should be ready for review now!

cc: @KlaasH

@lparrott lparrott changed the base branch from master to main August 5, 2021 16:44
@stacydein
Copy link

I'm the product manager for Cicero and I'm wondering if I can get an update on when this PR will be merged into production. We've had more customers running into this bug recently and I'd love to be able to share a fix timeline with them. Thanks! cc @coriobriensfdo @lparrott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:signed Community Community Contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants