import try_catch optuna-like #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takkyu2
requested changes
Jul 8, 2025
Collaborator
takkyu2
left a comment
takkyu2
left a comment
There was a problem hiding this comment.
Thank you very much for fixing this issue @L0ckR! The PR looks good to me.
There is one failing check, which you can fix by running:
uv run ruff format
After the failing check will pass, I will merge the PR.
In a separate PR, I will add an automatic formatting hook and some additional tests to avoid regression in the future.
takkyu2
approved these changes
Jul 8, 2025
Collaborator
takkyu2
left a comment
takkyu2
left a comment
There was a problem hiding this comment.
Thank you for fixing the format! 🎉 merging it into main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2