Skip to content

Conversation

@Yuki-Imajuku
Copy link
Collaborator

No description provided.

@Yuki-Imajuku Yuki-Imajuku requested a review from Copilot June 27, 2025 02:29

This comment was marked as outdated.

Yuki-Imajuku and others added 2 commits June 27, 2025 11:32
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Yuki-Imajuku Yuki-Imajuku requested a review from Copilot June 27, 2025 02:33

This comment was marked as outdated.

@Yuki-Imajuku Yuki-Imajuku requested a review from Copilot June 27, 2025 02:42

This comment was marked as outdated.

@Yuki-Imajuku Yuki-Imajuku requested a review from Copilot July 8, 2025 04:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for local visualization in ALE-Bench by extending the tool wrappers and Session API, updating utilities for image serialization, and expanding tests and documentation.

  • Introduce local_visualization in tool_wrappers and wire it through Session, including argument validation and elapsed‐time logging.
  • Provide new base64↔PIL utilities in utils.py to support image serialization in schemas.
  • Update tests to cover setup paths and session action logs for visualization, and refine type hints across the codebase.
  • Refresh documentation (README, CONTRIBUTING) and tighten CI type checking.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/ale_bench/tool_wrappers/local_visualization.py Added setup_local_visualization_paths, case_iter_func, and local_visualization implementation
src/ale_bench/session.py Integrated local_visualization method in Session, updated action‐log entries to include elapsed_time and added argument checks
src/ale_bench/utils.py Added base64_to_pil and pil_to_base64 helpers and refactored pil_to_base64jpeg
tests/tool_wrappers/test_local_visualization.py New parametrized tests for path setup of local visualization files
tests/test_session.py Expanded session tests to assert local_visualization action‐log entries and validate new argument checks
README.md Documented the new local_visualization API and streamlined development instructions
pyproject.toml Enforced stricter import grouping and updated linting config
.github/workflows/check.yml Upgraded mypy invocation to --strict
Comments suppressed due to low confidence (2)

src/ale_bench/utils.py:218

  • The functions base64_to_pil and pil_to_base64 reference base64 and io but these modules are not imported. Add import base64 and import io at the top of the file.
def base64_to_pil(base64_str: str) -> Image.Image:

src/ale_bench/utils.py:232

  • The type annotation uses Literal but Literal is not imported. Add from typing import Literal at the top of the file.
def pil_to_base64(image: Image.Image, image_format: Literal["JPEG", "PNG"] = "PNG") -> str:

@Yuki-Imajuku Yuki-Imajuku merged commit 2961753 into main Jul 8, 2025
5 checks passed
@Yuki-Imajuku Yuki-Imajuku deleted the feat/add-local-visualization-action branch July 8, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants