add a FirstAvailable mode for URLTest #3537
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mistakenly believed that `libresolv`'s `search` function worked correctly in NetworkExtension, but it seems only `getaddrinfo` does. This commit changes the behavior of the `local` DNS server in NetworkExtension to prefer DHCP, falling back to `getaddrinfo` if DHCP servers are unavailable. It's worth noting that `prefer_go` does not disable DHCP since it respects Dial Fields, but `getaddrinfo` does the opposite. The new behavior only applies to NetworkExtension, not to all scenarios (primarily command-line binaries) as it did previously. In addition, this commit also improves the DHCP DNS server to use the same robust query logic as `local`.
We do not have the `com.apple.developer.networking.multicast` entitlement and are unable to obtain it for non-technical reasons.
nekohasekai
force-pushed
the
dev-next
branch
11 times, most recently
from
b58d0a0 to
4e73574
Compare
nekohasekai
force-pushed
the
dev-next
branch
14 times, most recently
from
dfdd296 to
0a8b7a3
Compare
nekohasekai
force-pushed
the
dev-next
branch
5 times, most recently
from
9583e25 to
275d102
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new selection strategy for URLTest outbound groups. The changes add support for two selection modes (
min_latencyandfirst_available).Currently, the URLTest group select the min latency outbound. In my cases, the quailty of outbounds is not only related to the latency, but also other aspects. The outbounds' priority is alreay sorted when defined them in the config file as an array, so the task is to check their health periodically and choose the first available one.
What changes in this PR
select_modefield toURLTestOutboundOptionsinoption/group.go, along with theURLTestModetype and validation logic.protocol/group/urltest.goto support bothmin_latencyandfirst_availablestrategies.docs/configuration/outbound/urltest.mdselect_modeoption through constructors and struct fields.protocol/group/urltest.gofor clarity.