feat(*): first draft to type the Api reader #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierCuyp
requested changes
Jan 29, 2022
| Headers as nHeaders, | ||
| BodyInit as nBodyInit, | ||
| RequestInit as nRequestInit | ||
| } from 'node-fetch'; |
Contributor
There was a problem hiding this comment.
I now, this is only a lint change but we should import types here instead of the objects.
|
|
||
| mergeHeaders(baseHeaders: IsoHeaders, newHeaders: IsoHeaders): IsoHeaders { | ||
| const finalHeaders = new this.Headers(baseHeaders); | ||
| const finalHeaders = new this.Headers(baseHeaders as nHeaders); |
Contributor
There was a problem hiding this comment.
Here you force the type to be nHeaders, but how do you know what got ?
ftorrado
force-pushed
the
feat-typescript-mirror
branch
2 times, most recently
from
a62cf7c to
6afe755
Compare
ftorrado
force-pushed
the
feat-typescript-mirror
branch
from
6afe755 to
533ff32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.