Skip to content

fix: typo and dict access via dot notation bug #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaonengmiao wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: typo and dict access via dot notation bug #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eagle/traineagle3/cnets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ def __init__(self, config, ds_config, training_config, load_head=False, load_emb
else:
dschf = None
self.midlayer = LlamaDecoderLayeremb(config)
self.gradient_checkpointing = self.train_config.gradient_checkpointing
self.gradient_checkpointing = self.train_config["gradient_checkpointing"]
self.padding_idx = config.pad_token_id
self.vocab_size = config.vocab_size
self.hidden_size = config.hidden_size
Expand Down Expand Up @@ -588,7 +588,7 @@ def preprocess_function(examples):
# When construct draft model vocab,
# filter out samples which is longer than max_len,
# instead of truncating them.
if len(input_ids) > self.train_config.max_len:
if len(input_ids) > self.train_config["max_len"]:
continue
loss_mask = torch.ones_like(input_ids)
# print(i)
Expand Down
2 changes: 1 addition & 1 deletion eagle/traineagle3/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"num_workers": 2,
"max_len": 2048,
"config_path": "config.json",
"gradient_checkpoint": True
"gradient_checkpointing": True
}

from safetensors import safe_open
Expand Down