Adjusting the Stdlib to cope with our conceptual TC problem#253
Merged
sbscholz merged 3 commits intoSacBase:masterfrom Feb 13, 2026
Merged
Adjusting the Stdlib to cope with our conceptual TC problem#253sbscholz merged 3 commits intoSacBase:masterfrom
sbscholz merged 3 commits intoSacBase:masterfrom
Conversation
thomas3494
reviewed
Feb 13, 2026
thomas3494
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the time being (Feb 2026), the default-element generation for Tensor Comprehensions (TCs) does not (yet) follow the translation described in https://dl.acm.org/doi/10.1145/3412932.3412947. Instead, we do the following:
{ iv -> expr(iv) | iv < shp }is translated intoThis can lead to errors if the compiler finds the (potentially) illegal selection before optimising it away....
Fortunately, there is a manual work-around. If we write
the compiler will generate
This PR changes (hopefully all) such cases from the former into the latter.
See https://gitlab.sac-home.org/sac-group/sac2c/-/issues/2544 for a detailed description of the compiler issue.