Conversation
YuuuuuuYu
added
documentation
wlsh44
approved these changes
Feb 22, 2025
Contributor
wlsh44
left a comment
wlsh44
left a comment
There was a problem hiding this comment.
너무 늦게 확인드리네요.. 죄송합니다 ㅠㅠ
고생하셨습니다!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 작업 내용 설명
📢 그 외
ImageController에 ImageService가 들어가면서 다른 컨트롤러 테스트에 오류가 발생했습니다
=> WebMvcTest(Controller)를 세팅을 안하면 관련 없는 컨트롤러에서 ImageService에 대해 Mock 생성 오류가 발생합니다
ERD에서 Common에 해당하는 BaseEntity를 생성했는데 다른 엔티티에도 상속시키면 좋을 것 같습니다
어노테이션 추가는 1차 MVP 이후에 다시 확인하려고 하는데 피드백 부탁드립니다
현재 시간 기준으로 파일명을 생성하기 위해 DateTime 객체를 만들었는데 파일 생성 외에 사용하는게 아니면
image 패키지에 넣는게 좋을지 고민입니다
📌 관련 이슈
close #3