Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did some investigation into possible memory leaks. Two things that came up were:
This adds some fixes to Lobby as well as some new cleanup code to ensure data like the snapshots and the main allGameObjects list are cleared. I'm not positive this is the culprit of the memory leak but cleaning up the snapshots and explicitly clearing a bunch of the data is probably still a good call.
Changes
Added explicit teardown via Game.destroy(), SnapshotManager.destroy(), and GameStateManager.destroy(), wired listener-owning subsystems into cleanup (OngoingEffectEngine, GameStatisticsLogger), and updated Lobby so only active unfinished games count as ongoing. Permanently finished Bo1 / completed Bo3 games are now destroyed and released; the short between-games Bo3 case is still retained until transition. I also fixed removeUser() so it doesn’t try to send game state after cleanup.
Added tests in test\server\core\GameStateManagerDestroy.spec.ts and test\server\gamenode\Lobby.spec.ts.