Resource prompting for non-iniatie player#2204
Open
lightjedi5 wants to merge 4 commits intoSWU-Karabast:mainfrom
Open
Resource prompting for non-iniatie player#2204lightjedi5 wants to merge 4 commits intoSWU-Karabast:mainfrom
lightjedi5 wants to merge 4 commits intoSWU-Karabast:mainfrom
Conversation
Refactor prompt text generation to include initiative player status.
lightjedi5
requested review from
AMMayberry1,
CDMayberry,
Frugghi,
adbronico,
brianries,
danbastin and
moyerr
as code owners
Adds an overrided hasEnough selected that allows for 0 to be an option.
Collaborator
|
Hey thanks for the PR! Looks like some tests are failing, probably the logic around testing stuff for the setup phase is a bit brittle. Also, we'll want to add some new test cases to validate this new behavior. Lastly - could you ping me (Veld) in discord? We'll get you added to the dev channels |
AMMayberry1
reviewed
Feb 18, 2026
| return this.selectedCards[player.name].length >= this.minCardsToResource; | ||
| } | ||
|
|
||
| public override menuCommand(player: Player, arg: string) { |
Collaborator
There was a problem hiding this comment.
Why do we need this override here now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch Notes