Commonly requested commands (admin subcommands)#376
Commonly requested commands (admin subcommands)#376BubbaJoeX wants to merge 3 commits intoSWG-Source:masterfrom
Conversation
/admin setCount <integer> /admin messageTo <messageHandler> <timeToDelay (float)>
BubbaJoeX
changed the title
Fix for previous commit.
| sendConsoleMessage(self, "sets the weather for the current scene"); | ||
| sendConsoleMessage(self, "\\#00ffff setCount \\#bfff00 <integer> \\#."); | ||
| sendConsoleMessage(self, "sets the amount of a stackable item."); | ||
| sendConsoleMessage(self, "\\#00ffff sendMessageTo \\#bfff00 <messageHandler> <time as float> \\#."); |
There was a problem hiding this comment.
The command is just “messageTo” but here it’s listed as “sendMessageTo”
| float messageDelay; | ||
| if(st.hasMoreTokens()) { | ||
| message = st.nextToken(); | ||
| messageDelay = utils.stringToFloat(st.nextToken()); |
There was a problem hiding this comment.
With StringTokenizer you need to check hasMoreTokens() for each parameter. This currently has the potential to throw a null pointer exception because you’re calling nextToken() twice without knowing there are actually 2 more tokens (vs just 1 for the message param).
As an aside, these command scripts could really be cleaned up with a helper method and class used to validate params and return syntax because it’s so messy the way we currently do it over and over. A todo for another time.
| count = 500; | ||
| } | ||
| setCount(target, count); | ||
| sendConsoleMessage(self, "You have added " + count + " to " + target + " (" + getName(target) + ")"); |
There was a problem hiding this comment.
Not sure why these are console messages when standard pattern is system messages for admin command results. Not a big deal but curious deviation.
|
Bubba... changes... LFG! |
|
I'll get to these this month with Aconite's suggestions. |
3 participants
/admin setCount
/admin messageTo <timeToDelay (float)>
.gitignore for default IntelliJ IDEA build copies.
Note: /admin messageTo does not take any params, as it just calls the handler. In the future I may add a SUI textbox window to enter the message and delay line by line and parse it. TBD.