Conversation
…onents from DecompositionModel constructor
…ting and reconstructing
dsj976
approved these changes
Apr 8, 2026
Collaborator
dsj976
left a comment
There was a problem hiding this comment.
Thanks @robertvava, this is great. I have made some minor changes.
Collaborator
|
@robertvava this needs a last review by you before it can get merged, as I was the last pusher. |
Collaborator
Author
|
Thanks for the changes, looks great! |
dsj976
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR incorporates and abstract base class (ABC) called
DecompositionModelfor all ROM constructors (currentlyTruncatedSVDandOptDMD).DecompositionModelenforces two abstract methods:fit()andreconstruct(). It also contains a method_check_is_fitted()to check if a ROM has been fitted prior to reconstructing or forecasting.Additionally, this PR replaces
logger.exception()withlogger.error()where an error is raised outside an exception handler. This is best practice (see here).Closes #24.