-
Notifications
You must be signed in to change notification settings - Fork 14
Integration tests for "elemental3 customize" #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ipetrov117
wants to merge
8
commits into
SUSE:main
Choose a base branch
from
ipetrov117:customize-integration-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+282
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6266928 to
b9b1d59
Compare
b9b1d59 to
821335b
Compare
dirkmueller
reviewed
Jan 20, 2026
dirkmueller
reviewed
Jan 20, 2026
| contents: | ||
| inline: | | ||
| PermitRootLogin yes | ||
| - path: /var/lib/elemental/example/example.sh |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we put this into /usr/local/bin perhaps?
dirkmueller
approved these changes
Jan 20, 2026
Member
dirkmueller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wfm. thanks!
a139c9c to
b840e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests an implementation for integration tests that relate to the
elemental3 customizecommand.About the integration tests themselves:
elemental3ctl installtests. Between each test we do a cleanup to ensure that therun_vm.shscript can successfully build the next VM. The alternative to this was doing a cleanup after all tests, but this proved to be less effective and readable, as multiple needless properties and configurations had to be made so thatrun_vm.shcould boot 3 VMs next to one another.What is left? - Currently these tests are running with a release manifest that is taken directly from
devel:UnifiedCore:Tumbleweed. This needs to change, so that the tests take a release manifest from the respective OBS project that was created for the respective PR. To do this we would need to first land #319. After that the only change to this PR would be a reference to the respective release manifest, which should be a minimal change. Nevertheless, until that happens this PR will stay in Draft.