Remove hardcoded allowd origins apigw. #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes hardcoded CORS allowlisted origins from the API gateway HTTP server and makes them configurable via YAML.
Changes:
- Added
CORSconfiguration toAPIServerin the config model. - Updated API gateway HTTP server to read allowed origins from config instead of a hardcoded list.
- Updated
config.yamlto include the newapigw.api_server.cors.allowed_originssetting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/model/config.go | Introduces a CORS config struct and adds it to APIServer so origins can be configured via YAML. |
| internal/apigw/httpserver/service.go | Replaces hardcoded origins with s.cfg.APIGW.APIServer.CORS.AllowedOrigins when configuring gin-contrib/cors middleware. |
| config.yaml | Adds apigw.api_server.cors.allowed_origins values to the example/default config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.