Masv http status #243
Masv http status #243
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates HTTP status code handling and dependency versions. The changes move from using http.StatusTeapot (418) to more appropriate HTTP status codes for error handling, consolidate status code logic into a dedicated module, and update various dependencies to their latest versions.
Changes:
- Replace
http.StatusTeapotwithhttp.StatusBadRequestas the default for unknown OpenID4VCI errors - Refactor and consolidate HTTP status code mapping logic into
pkg/httphelpers/status.go - Update
lestrrat-go/jwxfrom v1 to v3 with corresponding API changes - Update multiple dependencies to newer versions
Reviewed changes
Copilot reviewed 9 out of 778 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/openid4vci/error.go | Changes default status code from 418 (Teapot) to 400 (Bad Request) for unknown errors |
| pkg/httphelpers/validator_test.go | Adds comprehensive test coverage for validator functionality |
| pkg/httphelpers/validator.go | Removes unused imports and StatusCode function (moved to status.go) |
| pkg/httphelpers/status_test.go | Adds comprehensive test coverage for status code mapping logic |
| pkg/httphelpers/status.go | Implements centralized HTTP status code mapping with error type detection and string inference |
| pkg/helpers/error.go | Adds HTTPStatus field and helper functions for explicit status code control |
| internal/issuer/apiv1/jwk.go | Updates jwx library usage from v1 to v3 API (Import instead of New, KeyID returns tuple) |
| go.mod | Updates multiple dependencies to newer versions |
| Makefile | Adds vc20 build tag to gosec and updates govulncheck parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 633 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.