-
Notifications
You must be signed in to change notification settings - Fork 35
feat(packages/sui-segment-wrapper): remove ga integration as code #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| clientId: 'clientId', | ||
| sessionId: 'sessionId' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have doubts on this changes, the rest is ok for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oriolpuig What's your doubt about? These values have changed because right now we save them manually on a JS template in GTM, before we used the gtag API with the snake case text style.
oriolpuig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏻
| } catch (e) {} | ||
|
|
||
| return id | ||
| export const waitForGAData = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We’re changing the strategy to obtain the GA4 IDs. With this pattern, we give the only source of truth to GTM.
Remove Google Analytics 4 integration
Description
This PR completely removes the Google Analytics 4 (GA4) tracking tag and all associated logic from the codebase. The primary motivation is to streamline our analytics strategy and reduce the complexity and performance overhead of third-party tracking scripts.
As part of this change, the responsibility for handling
client_idandsession_idis shifting. This data must now be set inlocalStorageso it can be picked up and used by Google Tag Manager (GTM). Teams will need to ensure their GTM configuration is set up to read these values fromlocalStorage.The changes include:
💣 BREAKING CHANGE 💣
This change is considered a BREAKING CHANGE and will result in a new major version.
localStorageRequirement: Theclient_idandsession_idare no longer handled automatically by the removed integration. They must be explicitly saved tolocalStoragefor GTM to consume.