Skip to content

Added tailwind and started header and footer#8

Merged
jbickar merged 14 commits into2.xfrom
ACHOO-112
Oct 7, 2025
Merged

Added tailwind and started header and footer#8
jbickar merged 14 commits into2.xfrom
ACHOO-112

Conversation

@jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Sep 9, 2025 •
edited
Loading

READY FOR REVIEW

Summary

  • Updated design
  • Moved the tables into tabs

Review By (Date)

Criticality

  • normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild
  3. Verify it build correctly
  4. I know the link to the different apps aren't working correctly.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@vercel
Copy link

vercel bot commented Sep 9, 2025

Unable to deploy a commit from a private repository on your GitHub organization to the SWS Developers' projects team on Vercel, which is currently on the Hobby plan. In order to deploy, you can:

  • Make your repository public or
  • Upgrade to Pro. A Pro subscription is required to deploy from a private organization repository.

To read more about collaboration on Vercel, click here.

@vercel
Copy link

vercel bot commented Sep 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
churro Ready Ready Preview Comment Oct 7, 2025 9:35pm

@jenbreese jenbreese requested a review from jbickar October 1, 2025 22:52
jenbreese
jenbreese commented Oct 2, 2025
View reviewed changes
app/layout.tsx
source_serif.variable,
stanford.variable,
)}>
<body className={cnb(
Copy link
Contributor Author

@jenbreese jenbreese Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbickar I think I would put your favions in a component and then link it here.

Copy link
Contributor

@jbickar jbickar Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude said:

In Next.js 13+ with the app directory, you should add metadata directly to the metadata object in layout.tsx` rather than creating a separate head component.

TIL. See commit a32aa1d

@jbickar
Copy link
Contributor

jbickar commented Oct 7, 2025

This looks great! I added favicons and hyperlinked the logo and title.

I'll add a separate ticket for styling the individual application pages.

@jbickar jbickar merged commit d0c4423 into 2.x Oct 7, 2025
2 checks passed
@jbickar jbickar deleted the ACHOO-112 branch October 7, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbickar jbickar jbickar approved these changes

Assignees

@jbickar jbickar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jenbreese @jbickar