Skip to content

ACHOO-119: Implement Local and Vercel Caching#21

Closed
jbickar wants to merge 47 commits into2.xfrom
ACHOO-119-20251015
Closed

ACHOO-119: Implement Local and Vercel Caching#21
jbickar wants to merge 47 commits into2.xfrom
ACHOO-119-20251015

Conversation

@jbickar
Copy link
Contributor

@jbickar jbickar commented Nov 15, 2025 •
edited
Loading

READY FOR REVIEW

DO NOT MERGE

  • I've created an integration branch, 2.x-integration, that likely will become a 3.x. This PR is for review purposes.

Summary

  • This PR introduces a comprehensive 5-minute hybrid caching system and a new applications overview page

Review By (Date)

  • 12/5/2025

Criticality

  • How critical is this PR on a 1-10 scale? 10/10 cache rules everything around me

Review Tasks

Cache System Testing

Local Development (File-based cache):

  1. Visit http://localhost:3000
  2. Fetch analytics data, note loading time
  3. Refresh page within 5 minutes - should load instantly (cached)
  4. Wait 5+ minutes, refresh - should fetch fresh data
  5. Check .cache directory for cache files

Vercel Testing:

  1. Deploy to Vercel staging environment
  2. Test cache behavior across multiple Vercel serverless instances
  3. Verify deployment-based cache invalidation
  4. Use "Clear Cache" buttons to test manual clearing

Applications Overview Page

Basic Functionality:

  1. Navigate to /applications
  2. Verify table auto-loads without manual refresh
  3. Check Pacific time display updates
  4. Confirm excluded UUIDs don't appear in table
  5. Test application links navigate to detail pages

Data Validation:

  1. Verify views/visits totals are accurate
  2. Check percentage calculations add up correctly
  3. Confirm Stanford Design System styling (alternating table rows, proper colors)

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • CHURRO

Associated Issues and/or People

  • JIRA ticket(s): ACHOO-119

Resources

jbickar added 30 commits October 10, 2025 11:36
@jbickar
ACHOO-119: local caching
1273192
@jbickar
Implement hybrid cache strategy with unstable_cache
abeeae0
@jbickar
Add clear cache button
04e5804
@jbickar
remove unused revalidate route
39ab225
@jbickar
Updated cache invalidation
f255fc4
@jbickar
Updated cache invalidation with revalidatePath
6d2af42
@jbickar
Add cache buster
5c80917
@jbickar
Update cache invalidation
aa0255b
@jbickar
add debug environment route
8aff255
@jbickar
WIP environment detection. Cache status:
402c96f 
Cache clearing works on local
Cache persists across instances on Vercel
Cache clearing does not work on Vercel
@jbickar
WIP: environment detection
d257b44
@jbickar
Move environment detection to runtime
54565a5
@jbickar
fixup! FE language; browser cache invalidation
e928b8d
@jbickar
WIP: move caching from API routes to pages. Add debug message
b195d0d
@jbickar
Add documentation
99c252c
@jbickar
Update cache lifetime to 1 minute for troubleshooting
077b575
@jbickar
Merge branch '2.x' into ACHOO-119-20251015
78d258e
@jbickar
WIP: update cache lifetime to 2 minutes
6ab816e
@jbickar
Merge branch '2.x' into ACHOO-119-20251015
155942d
@jbickar
fixup! resolve error from merge conflict resolution
1b4e20a
@jbickar
caching: application-layer timestamp validation
819d544
@jbickar
Update browser caching settings
adb9400
@jbickar
Disable browser caching
2a129c3
@jbickar
Add cache- busting query parameter to internal API call. Changed Cach…
5431cdc 
…e Mode from 'no-store' to 'reload'
@jbickar
WIP debug
e62c0cd
@jbickar
5 minute cache lifetime. update docs
140d263
@jbickar
Caching: Update applications pages to use same logic as homepage
4500ed9
@jbickar
WIP debugging
2327a8a
@jbickar
Update clear cache button functionality. Remove debugging code
6a0efbe
@jbickar
WIP: debugging
37b12b0
@jbickar jbickar requested a review from Copilot November 24, 2025 23:25
Copilot AI reviewed Nov 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbickar jbickar added the ai-generated Code in this PR was partially or wholly generated by AI label Nov 24, 2025
@jbickar jbickar self-assigned this Nov 24, 2025
@jbickar jbickar mentioned this pull request Nov 25, 2025
Closed
14 tasks
@jbickar jbickar requested a review from joegl December 9, 2025 17:00
@jbickar
Copy link
Contributor Author

jbickar commented Jan 13, 2026

Implemented in 3.x

@jbickar jbickar closed this Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@sherakama sherakama Awaiting requested review from sherakama

@pookmish pookmish Awaiting requested review from pookmish

@joegl joegl Awaiting requested review from joegl

Assignees

@jbickar jbickar

Labels

ai-generated Code in this PR was partially or wholly generated by AI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jbickar