Skip to content

ACHOO-138: Add .nvmrc#17

Merged
jbickar merged 1 commit into2.xfrom
ACHOO-138
Oct 13, 2025
Merged

ACHOO-138: Add .nvmrc#17
jbickar merged 1 commit into2.xfrom
ACHOO-138

Conversation

@jbickar
Copy link
Contributor

@jbickar jbickar commented Oct 10, 2025

READY FOR REVIEW

Summary

  • Specifying the Node.js version via .nvmrc and package.json "engines" eliminates environment inconsistencies across local development, CI/CD, and production deployments. This prevents hard-to-debug issues caused by Node.js version differences and ensures dependencies are installed with the correct runtime version.

Review By (Date)

  • Meh. Next week sometime, sure.

Criticality

  • How critical is this PR on a 1-10 scale? 3/10

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Follow setup instructions in README
  3. Check for errors

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Associated Issues and/or People

Resources

@vercel
Copy link

vercel bot commented Oct 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
churro Ready Ready Preview Comment Oct 10, 2025 10:47pm

@jbickar jbickar requested review from Copilot and sherakama October 10, 2025 22:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Node.js version specification through .nvmrc and package.json engines to ensure consistent development environments across local, CI/CD, and production deployments.

  • Added .nvmrc file specifying Node.js version 22
  • Added engines field to package.json with Node.js and npm version constraints
  • Enhanced README with detailed development setup instructions and environment variable documentation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.nvmrc Specifies Node.js version 22 for nvm
package.json Adds engines field with Node.js >=22.0.0 <23.0.0 and npm >=10.0.0 constraints
README.md Expands documentation with development setup, environment variables table, and deployment information

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jbickar jbickar self-assigned this Oct 10, 2025
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jbickar jbickar merged commit fc2cdc9 into 2.x Oct 13, 2025
2 checks passed
@jbickar jbickar deleted the ACHOO-138 branch October 13, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants