-
Notifications
You must be signed in to change notification settings - Fork 0
chore: add security .gitignore entries #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,41 @@ | ||||||||
| # Security — secrets & credentials (org-wide) | ||||||||
| # ============================================================================= | ||||||||
| # Secrets & Credentials — Apply org-wide | ||||||||
| # ============================================================================= | ||||||||
|
|
||||||||
| # Environment files | ||||||||
| .env | ||||||||
| .env.* | ||||||||
| !.env.example.template | ||||||||
|
|
||||||||
| # Private keys & certificates | ||||||||
| *.pem | ||||||||
| *.key | ||||||||
|
|
||||||||
| # Credential / secret files (broad patterns) | ||||||||
| *credentials* | ||||||||
| *secret* | ||||||||
|
Comment on lines
+16
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The wildcard rules Useful? React with 👍 / 👎. |
||||||||
|
|
||||||||
| # AWS-specific | ||||||||
| aws-credentials.env | ||||||||
| awsenv.local | ||||||||
|
|
||||||||
| # Deployment configs containing secrets | ||||||||
| .env.deploy | ||||||||
| samconfig.toml | ||||||||
|
|
||||||||
| # IDE workspace files (may contain tokens/keys) | ||||||||
| .idea/ | ||||||||
| .idea/workspace.xml | ||||||||
|
Comment on lines
+28
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛑 Logic Error: Line 29 is redundant since line 28 already ignores the entire
Suggested change
|
||||||||
|
|
||||||||
| # Terraform state (contains sensitive outputs) | ||||||||
| *.tfstate | ||||||||
| *.tfstate.backup | ||||||||
| .terraform/ | ||||||||
|
|
||||||||
| # Docker env overrides | ||||||||
| docker-compose.override.yml | ||||||||
|
|
||||||||
| # OS artifacts | ||||||||
| .DS_Store | ||||||||
| Thumbs.db | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛑 Critical Defect: Missing newline at end of file violates POSIX standards and can cause issues with line-based tools (grep, diff, git) and shell processing. Many CI/CD systems and linters enforce this requirement.
Suggested change
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛑 Security Risk: The wildcard patterns
*credentials*and*secret*will match files in all directories and could accidentally ignore legitimate code files. For example, files likeuser_credentials_validator.py,secret_manager.py, orcredentials_test.gowould be ignored, potentially excluding critical application code from version control.