♻️ Admin | Improve user search handling in dropdowns#1550
Open
zacharykeeping wants to merge 7 commits intomainfrom
Open
♻️ Admin | Improve user search handling in dropdowns#1550zacharykeeping wants to merge 7 commits intomainfrom
zacharykeeping wants to merge 7 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a reusable UserAutocomplete component to improve the mobile AdminUI experience when selecting users (type-to-search instead of scrolling), and replaces the existing user dropdowns in the Achievement/Reward edit dialogs.
Changes:
- Introduced
UserAutocompletecomponent based onMudAutocomplete, backed by leaderboard user data. - Updated
AchievementEditDialogto useUserAutocompletefor claiming achievements for a user. - Updated
RewardsEditDialogto useUserAutocompletefor redeeming rewards for a user.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/AdminUI/Components/UserAutocomplete.razor | New shared autocomplete + action button component for selecting a user with search. |
| src/AdminUI/Components/Dialogs/Rewards/RewardsEditDialog.razor | Replaces the user MudSelect with the new UserAutocomplete component for redeeming rewards. |
| src/AdminUI/Components/Dialogs/Achievements/AchievementEditDialog.razor | Replaces the user MudSelect with the new UserAutocomplete component for claiming achievements. |
…d sort users by name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1193
Moves user selection to MudAutocomplete to allow typing to search. Also creates a new component for this to prevent repetition.
Figure: The user can now type to search for users in the dropdown
No