Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the EagleEye documentation by introducing comprehensive secret management guidance and clarifying app registration naming conventions. The changes address issue #1459 by providing clear, actionable instructions for rotating client secrets for app registrations without requiring deletion and recreation.
Changes:
- Added a new comprehensive guide for managing and rotating client secrets for Engine and Portal app registrations
- Updated existing documentation to reference the new secret management guide
- Clarified that the three app registrations created by the Master app use the
SSW.EagleEyeprefix
Reviewed changes
Copilot reviewed 6 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| content/docs/EagleEye/secret-management-app-registrations.mdx | New comprehensive guide covering secret rotation via Azure Portal and CLI, with step-by-step instructions for updating Key Vault values and restarting services |
| content/docsTableOfContents/EagleEye/toc.mdx | Added new secret management guide to documentation navigation |
| content/docs/EagleEye/step-3-install-from-marketplace.mdx | Added reference link to secret management guide |
| content/docs/EagleEye/step-2-app-registrations.mdx | Added reference link to secret management guide |
| content/docs/EagleEye/redeploy-cleanup.mdx | Updated guidance to reference secret management guide instead of just mentioning deletion |
| content/docs/EagleEye/app-registrations-reference.mdx | Clarified that app registrations use SSW.EagleEye prefix (Engine, Api, Portal) |
| public/EagleEye/Guides/CA-Stop.png | New screenshot showing container app stop/start functionality |
| public/EagleEye/Guides/3-App-Registrations.png | New screenshot showing the three EagleEye app registrations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AttackOnMorty
requested changes
Feb 26, 2026
… in roles and permissions
AttackOnMorty
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/SSWConsulting/SSW.EagleEye/issues/1459
Partially done via: OpenCode (OpenAI Codex 5.3) & GitHub Copilot (Claude Sonnet 4.6)
This pull request introduces improved clarity and guidance around app registration naming conventions and secret management for the EagleEye application. The most significant change is the addition of a comprehensive guide for rotating client secrets, along with updates to documentation to reference this new guide and clarify naming conventions for app registrations.
Secret Management Enhancements:
secret-management-app-registrations.mdx, detailing step-by-step instructions for rotating expired or expiring client secrets for theEngineandPortalapp registrations, updating Key Vault values, and restarting the Portal app if needed. This guide includes both Azure Portal and Azure CLI instructions, recommended roles, and best practices.redeploy-cleanup.mdx) to reference the new secret management guide for rotating secrets, rather than simply deleting and recreating them.step-2-app-registrations.mdx,step-3-install-from-marketplace.mdx). [1] [2] [3]App Registration Naming Clarification:
SSW.EagleEyeprefix, improving consistency and reducing ambiguity. [1] [2] [3] [4]