Skip to content

FreeBSD CI: Switch to 15.0-RELEASE and enable testing #8306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arrowd wants to merge 8 commits into
base: master
Choose a base branch
from
Open

FreeBSD CI: Switch to 15.0-RELEASE and enable testing #8306

arrowd wants to merge 8 commits into from
+33 −17

Conversation

@arrowd
Copy link
Contributor

@arrowd arrowd commented Dec 16, 2025

No description provided.

@gemini-code-assist
Copy link

gemini-code-assist bot commented Dec 16, 2025

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

alexey-tikhonov
alexey-tikhonov reviewed Dec 16, 2025
View reviewed changes
.github/workflows/build.yml Outdated
echo "::group::Testing"
# Tests don't work yet
#gmake check
gmake -j $(sysctl -n hw.ncpu) check
Copy link
Member

@alexey-tikhonov alexey-tikhonov Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if '-j' will be "stable" but let's see...

Copy link
Contributor Author

@arrowd arrowd Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux jobs seem to run tests with -j

sssd/.github/workflows/build.yml

Line 41 in 2b43681

make CFLAGS+="$SSS_WARNINGS -Werror" -j$PROCESSORS check

Copy link
Member

@alexey-tikhonov alexey-tikhonov Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I wonder if it was the reason of randomly failing
https://github.com/SSSD/sssd/actions/runs/19703082331/job/56443862911

@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Dec 16, 2025
@arrowd
Copy link
Contributor Author

arrowd commented Dec 16, 2025

Why doesn't FreeBSD CI run automatically?

@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Dec 16, 2025

Why doesn't FreeBSD CI run automatically?

Some CI jobs require manual approval by a maintainer with write access.

@arrowd
Copy link
Contributor Author

arrowd commented Dec 17, 2025

Can the FreeBSD build be restarted, please? It failed due to a temporary fluke on the FreeBSD pkg repository side.

@arrowd arrowd marked this pull request as draft December 17, 2025 17:28
@arrowd
Copy link
Contributor Author

arrowd commented Dec 17, 2025

Thanks. I'll work on the last test failure, although I can't reproduce it locally.

@arrowd arrowd marked this pull request as ready for review December 26, 2025 14:45
@arrowd
Copy link
Contributor Author

arrowd commented Dec 26, 2025

I finally managed to get make check pass, but unfortunately had to skip those failing pam-srv-tests. The test passes for me localy and I even tried running the same VM image that cross-platform-actions use - no luck, the test passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-tikhonov alexey-tikhonov alexey-tikhonov left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

no-backport This should go to target branch only.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arrowd @alexey-tikhonov