Skip to content

updating test case names to conform to guidelines #8215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
danlavu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updating test case names to conform to guidelines #8215

danlavu wants to merge 1 commit into from

Conversation

@danlavu
Copy link

@danlavu danlavu commented Nov 20, 2025

No description provided.

@danlavu danlavu requested a review from sumit-bose November 20, 2025 14:21
@danlavu danlavu added Waiting for review Tests Trivial A single reviewer is sufficient to review the Pull Request labels Nov 20, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 20, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates two test case names in src/tests/system/tests/test_authentication.py to conform to what appears to be an established naming guideline within the file. The new names are more descriptive and consistent with other tests, which improves code readability and maintainability. The changes are correct and I have no suggestions for improvement.

sumit-bose
sumit-bose approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thank you for the fixes, ACK.

bye,
Sumit

@sumit-bose
Copy link
Contributor

sumit-bose commented Nov 20, 2025

Hi,

the backports of the test are still evaluated so I guess it would make sense to wait until the backports are commited before merging this fix with the matching backport labels.

bye,
Sumit

@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Nov 20, 2025

the backports of the test are still evaluated so I guess it would make sense to wait until the backports are commited before merging this fix with the matching backport labels.

Or maybe merge this to 'master' only and rename directly in the test backport PR..?

@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Nov 27, 2025

it would make sense to wait until the backports are commited

Adding 'blocked' label due to this ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sumit-bose sumit-bose sumit-bose approved these changes

@madhuriupadhye madhuriupadhye madhuriupadhye approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sumit-bose sumit-bose

@madhuriupadhye madhuriupadhye

Labels

Blocked Tests Trivial A single reviewer is sufficient to review the Pull Request Waiting for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danlavu @sumit-bose @alexey-tikhonov @madhuriupadhye