Gdm updates #226
Gdm updates #226
Conversation
Summary of ChangesHello @spoore1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces updates to the GDM-related testing utilities within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces updates for GDM testing and vfido_passkey_register in sssctl. The changes include adjusting a wait time in GDM interactions and making the passkey registration output parsing more robust. My review focuses on improving maintainability and correctness. I've pointed out a hardcoded path in gdm.py that could be refactored. For sssctl.py, I've identified a couple of issues in the new parsing logic, including shadowing a Python built-in and a potential bug due to a missing string strip operation, and I've provided a suggestion to fix them.
|
Gemini comments seem legit, please take a look at them. In addition, CI is failing. Can you take a look? |
The sssctl method vfido_passkey_register returned unexpected output which affected the return value and caused test failures. Modifying to check output starts with passkey: before returning. If not found, it raises a ValueError.
Small timing change with the check_home_screen wait. Drop unnecessary steps in login_idp. Add scauto_path to misc globals.
|
Ok, now only CI is failing. Reason: |
2 participants
Updates needed for GDM related testing including with vfido passkey register for sssctl. Updates partially for timing and functionality.