ロボットを円軌道で移動させるtactic #488
Merged
ロボットを円軌道で移動させるtactic #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShotaAk
requested changes
May 10, 2025
Contributor
ShotaAk
left a comment
ShotaAk
left a comment
There was a problem hiding this comment.
動作OKです！
Lintで失敗しているので修正お願いします。 🙏
StopとAdjustPositionは使われてないので削除すれば治るはず。
https://github.com/SSL-Roots/consai_ros2/actions/runs/14925175393/job/41928323527?pr=488
>>>
build/consai_game/test_results/consai_game/flake8.xunit.xml: 2 tests, 0 errors, 2 failures, 0 skipped
- consai_game.flake8 F401 (./consai_game/tactic/circular_move.py:21:1)
<<< failure message
'consai_game.utils.adjust_position_to_field.AdjustPosition' imported but unused:
from consai_game.utils.adjust_position_to_field import AdjustPosition
>>>
- consai_game.flake8 F401 (./consai_game/play/factory/circular_plays.py:24:1)
<<< failure message
'consai_game.tactic.stop.Stop' imported but unused:
from consai_game.tactic.stop import Stop
>>>
agich073
requested review from
ShotaAk,
Yamam0t0,
nabekuro0104,
tilt-silvie and
uchikun2493
and removed request for
tilt-silvie
Contributor
Author
|
Lintのエラーを修正しました |
ShotaAk
reviewed
May 15, 2025
| # limitations under the License. | ||
|
|
||
| """ | ||
| 条件に応じてディフェンス動作やキックやパスを切り替えるTactic |
Contributor
There was a problem hiding this comment.
コメントの修正お願いします！
Suggested change
| 条件に応じてディフェンス動作やキックやパスを切り替えるTactic | |
| ボールを中心に回転するTactic |
ShotaAk
reviewed
May 15, 2025
| from consai_msgs.msg import MotionCommand | ||
|
|
||
|
|
||
| class BallCentricMover(TacticBase): |
Contributor
There was a problem hiding this comment.
composite_ball_centric_mover.pyと同じ・・・？
多分、ファイルの消し忘れだと思います！
ShotaAk
requested changes
May 15, 2025
Contributor
ShotaAk
left a comment
ShotaAk
left a comment
There was a problem hiding this comment.
動きはOKです！
コメントの修正とファイルの削除（もしくは修正）をお願いします！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケット: https://github.com/orgs/SSL-Roots/projects/7?pane=issue&itemId=108992680
追加したファイル
中心座標 (center_x, center_y)