-
Notifications
You must be signed in to change notification settings - Fork 1
ball position modelを追加 #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ShotaAk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
実装ありがとう〜
大まかなクラスの構造はOK。
world_modelの扱い方を整えたいのでコメントしました!
consai_game/consai_game/world_model/world_model_provider_node.py
Outdated
Show resolved
Hide resolved
consai_game/consai_game/world_model/world_model_provider_node.py
Outdated
Show resolved
Hide resolved
|
test_scenario_kickoff.py failed. Failure logs: https://github.com/SSL-Roots/consai_ros2/actions/runs/14420255921/artifacts/2932829850 |
|
@ShotaAk 修正しました!!!!!!! |
|
test_scenario_kickoff.py failed. Failure logs: https://github.com/SSL-Roots/consai_ros2/actions/runs/14420444485/artifacts/2932872320 |
|
test_scenario_stop.py failed. Failure logs: https://github.com/SSL-Roots/consai_ros2/actions/runs/14420482703/artifacts/2932878159 |
|
test_scenario_ball_placement.py failed. Failure logs: https://github.com/SSL-Roots/consai_ros2/actions/runs/14424842307/artifacts/2933932955 |
|
test_scenario_stop.py failed. Failure logs: https://github.com/SSL-Roots/consai_ros2/actions/runs/14424849436/artifacts/2933935126 |
ShotaAk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
consai_examples/consai_examples/observer/ball_position_observer.py でやってたことほぼそのまま
以下確認用
不安点
callback_detection_tracedの中で更新するようにしたが場所あっている?