Skip to content

Conversation

@nabekuro0104
Copy link
Contributor

consai_examples/consai_examples/observer/ball_position_observer.py でやってたことほぼそのまま

以下確認用

            print(f'is_in_our_defense_area: {self.world_model.ball_position.is_in_our_defense_area()}')
            print(f'is_in_their_defense_area: {self.world_model.ball_position.is_in_their_defense_area()}')
            print(f'is_in_our_side: {self.world_model.ball_position.is_in_our_side()}')
            print(f'is_in_their_side: {self.world_model.ball_position.is_in_their_side()}')
            print(f'is_outside_of_left: {self.world_model.ball_position.is_outside_of_left()}')
            print(f'is_outside_of_right: {self.world_model.ball_position.is_outside_of_right()}')
            print(f'is_outside_of_top: {self.world_model.ball_position.is_outside_of_top()}')
            print(f'is_outside_of_bottom: {self.world_model.ball_position.is_outside_of_bottom()}')
            print(f'is_outside_of_left_with_margin: {self.world_model.ball_position.is_outside_of_left_with_margin()}')
            print(f'is_outside_of_right_with_margin: {self.world_model.ball_position.is_outside_of_right_with_margin()}')
            print(f'is_outside_of_top_with_margin: {self.world_model.ball_position.is_outside_of_top_with_margin()}')
            print(f'is_outside_of_bottom_with_margin: {self.world_model.ball_position.is_outside_of_bottom_with_margin()}')
            print(f'is_outside_with_margin: {self.world_model.ball_position.is_outside_with_margin()}')

不安点

callback_detection_tracedの中で更新するようにしたが場所あっている?

@nabekuro0104 nabekuro0104 requested a review from ShotaAk April 11, 2025 14:24
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実装ありがとう〜
大まかなクラスの構造はOK。
world_modelの扱い方を整えたいのでコメントしました!

@github-actions
Copy link

test_scenario_kickoff.py failed. Failure logs: https://github.com/SSL-Roots/consai_ros2/actions/runs/14420255921/artifacts/2932829850

@nabekuro0104
Copy link
Contributor Author

@ShotaAk 修正しました!!!!!!!

@github-actions
Copy link

test_scenario_kickoff.py failed. Failure logs: https://github.com/SSL-Roots/consai_ros2/actions/runs/14420444485/artifacts/2932872320

@github-actions
Copy link

test_scenario_stop.py failed. Failure logs: https://github.com/SSL-Roots/consai_ros2/actions/runs/14420482703/artifacts/2932878159

@github-actions
Copy link

test_scenario_ball_placement.py failed. Failure logs: https://github.com/SSL-Roots/consai_ros2/actions/runs/14424842307/artifacts/2933932955

@github-actions
Copy link

test_scenario_stop.py failed. Failure logs: https://github.com/SSL-Roots/consai_ros2/actions/runs/14424849436/artifacts/2933935126

Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShotaAk ShotaAk merged commit fac23af into main Apr 13, 2025
12 of 13 checks passed
@ShotaAk ShotaAk deleted the feature/ball_position_model branch April 13, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants