Conversation
package.xml
Outdated
There was a problem hiding this comment.
Do we need / want this repo to be a ROS package? The way we're integrating it into the software repo, this is not required.
There was a problem hiding this comment.
Agreed, this is not necessary.
analysis/src/bin/trajectory_gen.rs
Outdated
There was a problem hiding this comment.
I expect we'll have multiple things living in the analysis folder that might not all be written in rust. Could this simulator live in a subdirectory?
There was a problem hiding this comment.
Yes, I still need to move it.
There was a problem hiding this comment.
Having started to pull this into the coach software, it'd be super cool if these types were in a namespace. These are very generic names to be unqualified type names.
There was a problem hiding this comment.
Ok, I expect to make some big changes still, so integrate it with caution.
There was a problem hiding this comment.
@barulicm do you mean I should just add AteamControls in front of the type names, or I should try to use a proper C++ namespace? It seems like it doesn't fit to use C++ features in this .h header file.
|
Maybe this won't be for this PR, but I need to give you some math to convert torques to currents. Might as well do the conversion up on the H7 where we have lots of horsepower. |
nickwitten
force-pushed
the
dev/nick/bangbang
branch
from
2e3da6b to
a8ce665
Compare
nickwitten
force-pushed
the
dev/nick/bangbang
branch
from
a8ce665 to
f29c0ff
Compare
|
@barulicm @chachmu @guyfleeman please take a look when you get some time. I organized it into commits, if that makes it easier to view. Thanks! |
3 participants
Bang Bang Trajectory Generation