Skip to content

to allow creation of empty object #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himanshu230987 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

to allow creation of empty object #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4969111
to allow creation of empty object
himanshu230987 Dec 2, 2022
155d4be
Map field comes as dictionary not list
himanshu230987 Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions avro_to_python/templates/fields/mapField.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{%- block map %}
def set_{{name}}(self, values: list) -> None:

def set_{{name}}(self, values) -> None:
if isinstance(values, dict):
self.{{name}} = values
return

self.{{name}} = []
if isinstance(values, list):
for item in values:
Expand Down Expand Up @@ -60,6 +63,6 @@
else:
raise TypeError("Field '{{name}}' should be type list")

def get_{{name}}(self) -> list:
def get_{{name}}(self):
return self.{{name}}
{%- endblock -%}
{%- endblock -%}
9 changes: 6 additions & 3 deletions avro_to_python/templates/files/record.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@
class {{file.name}}(object):

{% include 'partials/avroSchema.j2'|indent(-4) %}
def __init__(self, obj: Union[str, dict, '{{file.name}}']) -> None:
if isinstance(obj, str):
def __init__(self, obj: Union[str, dict, '{{file.name}}'] = None) -> None:
if obj is None:
return

elif isinstance(obj, str):
obj = json.loads(obj)

elif isinstance(obj, type(self)):
Expand All @@ -22,4 +25,4 @@ class {{file.name}}(object):
{% for name, field in file.fields.items() -%}
{% include 'fields/fieldFactory.j2' %}
{% endfor -%}
{%- endblock -%}
{%- endblock -%}