Conversation
|
@AlessandroPampado99 BundleSolver had 1e-4 as default tolerance that is larger than the default 1e-5. Here we propose differentiated tolerances for IB and non-IB and their customization through pytest calls e.g. "pytest --rel=0.0001" This is ready to merge when CI passes. Subsequently #20 |
|
@davide-f tests are not passing for the same reason about tolerance FAILED test/test_investmentblock.py::test_investment[7: 3n_3c_1gext_1h_1bext_2l.xlsx] - assert 746029920.6 == 736979038.3716856 ± 7.4e+04 comparison failed I'm gonna take a look at it |
|
@AlessandroPampado99 please share a complete instance that is failing for this case With the instance, we check if the value is truly random. We have randomness in the generation of instances right? In the future we shall improve tests to facilitate to recognize errors in the conversions and errors in smspp. |
No description provided.