Closed
Conversation
added flags for compiling for AMD Instinct MI300 , MI325 and MI350 suggest to set default compilation for AMD Instinct GPUs to MI200 and MI300
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1847 +/- ##
==========================================
- Coverage 51.53% 51.53% -0.01%
==========================================
Files 267 267
Lines 60735 60735
==========================================
- Hits 31302 31301 -1
- Misses 29433 29434 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
hi Leopold, we'll only accept PRs against the devel branch - I will close this one, but can add your modifications into one of mine shortly. thanks for the update :) |
Author
|
[AMD Official Use Only - AMD Internal Distribution Only]
Thank you very much !
From: daniel peter ***@***.***>
Date: Monday, November 24, 2025 at 1:01 PM
To: SPECFEM/specfem3d ***@***.***>
Cc: Grinberg, Leopold ***@***.***>, Author ***@***.***>
Subject: Re: [SPECFEM/specfem3d] Update Makefile.in (PR #1847)
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
[https://avatars.githubusercontent.com/u/5815257?s=20&v=4]danielpeter left a comment (SPECFEM/specfem3d#1847)<#1847 (comment)>
hi Leopold, we'll only accept PRs against the devel branch - I will close this one, but can add your modifications into one of mine shortly. thanks for the update :)
—
Reply to this email directly, view it on GitHub<#1847 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARALBXBFLJU53ZFYW2XDGR336NBV7AVCNFSM6AAAAACNA3G56KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNZSGA2TONRQHE>.
You are receiving this because you authored the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added flags for compiling for AMD Instinct MI300 , MI325 and MI350
suggest to set default compilation for AMD Instinct GPUs to MI200 and MI300