Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 83.45% 83.45%
=======================================
Files 8 8
Lines 417 417
=======================================
Hits 348 348
Misses 69 69
Continue to review full report at Codecov.
|
DarrienG
reviewed
Mar 3, 2019
| static std::vector<int> semids; | ||
| /*! The global list of tentacles used for communication with children */ | ||
| static std::vector<std::shared_ptr<tentacle>> tentacles; | ||
| static std::vector<tentacle*> tentacles; |
Author
There was a problem hiding this comment.
I forget why we wanted to remove them. Probably had to do with shm
|
|
||
| int octopOS::shmid = 0; | ||
| int octopOS::tentacle_ids[NUMMODULES]; | ||
| std::vector<std::shared_ptr<tentacle>> octopOS::tentacles; |
Author
There was a problem hiding this comment.
This whole branch is way behind master I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't check for memory leaks yet ¯\_(ツ)_/¯