Merged
Conversation
…to feature/#90-maps-api-connect
|
Caution Review failedThe pull request is closed. Walkthrough이 변경사항은 지도(맵) API 연동을 위한 데이터 구조, 리포지토리, 네비게이션, UI 컴포저블, DTO 및 서비스 계층에 새로운 메서드와 필드를 추가하고, 기존의 네비게이션 함수와 데이터 모델을 확장하여 타운 및 장소 ID를 전달하도록 전반적으로 개선하였습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant UI
participant ViewModel
participant Repository
participant RemoteDataSource
participant Service
participant API
UI->>ViewModel: fetchUserInfo()
ViewModel->>Repository: getPlaces(townId, mainTagId, subTagAIdList, subTagBIdList)
Repository->>RemoteDataSource: getPlaces(townId, isBookmarkSearch, mainTagId, subTagAIdList, subTagBIdList)
RemoteDataSource->>Service: getPlaces(townId, isBookmarkSearch, mainTagId, subTagAIdList, subTagBIdList)
Service->>API: HTTP GET /api/places
API-->>Service: BaseResponse<GetPlacesResponseDto>
Service-->>RemoteDataSource: GetPlacesResponseDto
RemoteDataSource-->>Repository: GetPlacesResponseDto
Repository-->>ViewModel: Result<List<PlaceEntity>>
ViewModel-->>UI: Update placeList state
sequenceDiagram
participant MainScreen
participant MainNavigator
participant NavController
participant MapsScreen
MainScreen->>MainNavigator: navigateToMaps(mapsType, townId, placeId, navOptions)
MainNavigator->>NavController: navigateMaps(mapsType, townId, placeId, navOptions)
NavController->>MapsScreen: MapsRoute(mapsType, townId, placeId)
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (20)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
🌱 작업한 내용
🌱 PR 포인트
📸 스크린샷
📮 관련 이슈
Summary by CodeRabbit
신규 기능
기능 개선
버그 수정
내비게이션