Merged
Conversation
Member
|
Looks like everything works. I've refactored the code to split the patching logic from the UI logic. I tested it as far as I could, but please re-test it yourself to make sure I haven't broken anything related to the SMB2 logic. Will merge after you confirm that everything is still working fine. |
telinc1
approved these changes
Nov 8, 2025
Contributor
Author
|
Looks all good here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just joined as part of the new SMB2 Team.
One of the issues we have with SMB2 romhacking is people have several different versions of the SMB2 rom. There are two revisions of SMB2, Rev 0 and Rev A (Revision A is basically a 1.1 with some minor bugfixes), and those versions can also have different iNES headers. Some roms are updated with iNES v2.0 headers.
To alleviate this issue, I've written some logic to correct the version of the SMB2 base rom provided by the user to match what the BPS patch is requiring.
There are two bps patches included that convert Rev 0 <-> Rev A. I've embedded them into the js as Base64 strings. They could just as easily be fetched from the server if that makes more sense. I just wasn't sure how to do that from within the CodePen sandbox.