Scripts for building SMLP in virtual environment#51
Scripts for building SMLP in virtual environment#51
Conversation
mdmitry1
left a comment
mdmitry1
left a comment
There was a problem hiding this comment.
Added build benchmarks
mdmitry1
left a comment
mdmitry1
left a comment
There was a problem hiding this comment.
These script enable SMLP development is virtual environment.
Validated in Ubuntu 24.04
mdmitry1
left a comment
mdmitry1
left a comment
There was a problem hiding this comment.
Removed unnecessary temporary files
mdmitry1
left a comment
mdmitry1
left a comment
There was a problem hiding this comment.
Improved Docker container usability
mdmitry1
left a comment
mdmitry1
left a comment
There was a problem hiding this comment.
Viewed one more file
mdmitry1
left a comment
mdmitry1
left a comment
There was a problem hiding this comment.
Added boost temporary files cleanup command
mdmitry1
left a comment
mdmitry1
left a comment
There was a problem hiding this comment.
Added regression support
mdmitry1
left a comment
mdmitry1
left a comment
There was a problem hiding this comment.
Added instructions for running regression in Docker environment
mdmitry1
left a comment
mdmitry1
left a comment
There was a problem hiding this comment.
Switched to wheel-based build
mdmitry1
left a comment
mdmitry1
left a comment
There was a problem hiding this comment.
Fixed issues in Dockerfile and README.md
commit 1912a6e1f2cabfec6ba1f1dfde0e0b5d9b3237a2 (HEAD -> master, origin/master, origin/HEAD)
Author: Franz Brauße <dev@karlchenofhell.org>
Date: Sat Mar 7 15:15:20 2026 +0100
fix compilation issue for macosx-sdk 26:
mdmitry1
left a comment
mdmitry1
left a comment
There was a problem hiding this comment.
Rebuild wheel after commit in kay repository
fbrausse
left a comment
fbrausse
left a comment
There was a problem hiding this comment.
I don't like having venv as a top-level directory due to clutter. As these files seem part of some specific installation instructions, which are not a hard requirement, they should be inside some build- or installation-specific directory preferrably not called venv, because that is a name users typically use to setup their own virtual environments. My suggestion would be to put all these "support scripts" into a directory called scripts instead.
There was a problem hiding this comment.
Why would we put a binary into the source code tree of SMLP? The place for binary release files is on our releases page (currently only Github).
There was a problem hiding this comment.
From my point of view, this patch is adding technical debt. Let's instead fix our usage of matplotlib properly.
| #!/usr/bin/tcsh -f | ||
| mkdir -p $HOME/smlp_shared | ||
| if( ! $?TZ ) setenv TZ `readlink /etc/localtime | sed 's@/usr/share/zoneinfo/@@'` | ||
| docker run -e TZ=$TZ -v $HOME/smlp_shared:/shared -it mdmitry1/smlp-dev:latest $* |
There was a problem hiding this comment.
What's the purpose of setting TZ here? Is it a workaround of some sort? If so, could you add a comment describing what's accomplished by that?
| scipy==1.11.4 | ||
| seaborn | ||
| tensorflow==2.15.1 | ||
| z3-solver==4.8.12 |
There was a problem hiding this comment.
Version pinning should be avoided as much as possible. It's not a permanent solution. For instance, we already confirmed that newer versions of tensorflow work. Why are they pinned?
|
|
||
| #tkdiff patch for https://bugs.launchpad.net/bugs/2139062 | ||
| COPY tkagg_patch.sh . | ||
| RUN chmod +x tkagg_patch.sh |
There was a problem hiding this comment.
See also my comment on the patch file itself. Wouldn't it be better to ship these changes as a separate branch if they are indeed required?
2 participants
Recommended for SMLP developers