Skip to content

Update version to 1.21.11-2.72.1 and correct config path documentation #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twisti-dev merged 2 commits into from
Mar 29, 2026
+3 −3
Merged

Update version to 1.21.11-2.72.1 and correct config path documentation #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aa1d38
feat: update version to 1.21.11-2.72.1 and correct config path docume…
twisti-dev Mar 29, 2026
862257a
Merge branch 'version/1.21.11' into fix/config-versioning
twisti-dev Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ org.jetbrains.dokka.experimental.gradle.pluginMode=V2Enabled
javaVersion=25
mcVersion=1.21.11
group=dev.slne.surf
version=1.21.11-2.72.0
version=1.21.11-2.72.1
relocationPrefix=dev.slne.surf.surfapi.libs
snapshot=false
2 changes: 1 addition & 1 deletion ...f-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/config/SpongeConfigClass.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ sealed class SpongeConfigClass<C>(
/**
* Sets the path in the config file where the version number is stored.
*
* Defaults to `"config-version"`. Call this in the `init` block before
* Defaults to `"_config_version"`. Call this in the `init` block before
* any migration registrations if you need a custom key.
Comment on lines 112 to 116
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated default version key here is now "_config_version", but ConfigMigrationBuilder.versionKey KDoc still states the default is "config-version" (see ConfigMigrationBuilder.kt). Consider updating that KDoc too so docs are consistent and users don’t get conflicting guidance on the default schema version path.

Copilot uses AI. Check for mistakes.
*
* @param path the path components to the version key
Expand Down
2 changes: 1 addition & 1 deletion .../surf-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/config/SurfConfigApi.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ interface SurfConfigApi {
configFolder: Path,
configFileName: @JsonConfigFileNamePattern String,
): SpongeConfigManager<C> =
createSpongeYmlConfigManager(configClass, configFolder, configFileName, ConfigMigrationBuilder())
createSpongeJsonConfigManager(configClass, configFolder, configFileName, ConfigMigrationBuilder())

/**
* Creates a Sponge JSON configuration manager.
Expand Down