This repository was archived by the owner on Jan 14, 2025. It is now read-only.
Feature/machine dependent filters #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create action for change of machine tag (other tags choice change) - adapt refresh_ui to also update machine tag - outsource machine tag change to GUI Widget bc. home_page.py needs same functionality (debatable choice)
- connect signal of machine Combobox - update filters when machine changes - add filter to get_current_routines
Contributor
|
@wyrnat Thanks so much for the contribution! It has been years since this PR (sorry for the inactivity in this repo! Recent activities have been happening in the new location) so I feel maybe we have to do some work on the code to adapt it to the new code base. I'll leave the PR as is and archive this old repo (to not cause further confusion). Talk to you in the new repo soon! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not tested: Please review my issue #9 so I can test it on the latest version
Execution
what
why
how
Supporting information
Badger Plugins
The directory tags was added to Badger Plugins. As examples, LCLS and XFEL was added.
The init file conatins of a dictionary which contain the tags. The configs file only defines name and badger-opt as dependency
closes #10