Remove bundled cryptographic implementations in favor of OpenSSL/WolfSSL #828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Bundled Cryptographic Code from SIPp
Summary
Remove the option to build SIPp without an external SSL/TLS library. Building SIPp now requires either OpenSSL (≥1.1.1) or WolfSSL (≥3.15.0).
Rationale
This is a security fix, not a feature removal.
The bundled cryptographic code:
Additional benefits:
Practicality:
SIPp is a testing tool. It runs on developer machines, CI systems, and test labs. These environments have OpenSSL. Users requiring minimal footprint can use WolfSSL, which is specifically designed for constrained systems.
Compatibility
OpenSSL 1.1.1 was released in September 2018. Distributions still shipping older OpenSSL are either EOL or running with known security vulnerabilities. We should not compromise SIPp's security to support systems that are themselves insecure.
For reference, OpenSSL 1.1.1 is available in: