Skip to content

Fix W1049 system names #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesliech1004 merged 3 commits into from
Jul 2, 2025
Merged

Fix W1049 system names #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4ea3a8
update scheduled tests
kelle Jul 1, 2025
bf60c0c
make wise1049 names simbadable
kelle Jul 1, 2025
1b41960
updated tests
kelle Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions data/source/wise_j104915.57-531906.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@
],
"CompanionRelationships": [
{
"companion_name": "WISE J104915.57-531906.1A",
"companion_name": "WISE J1049-5319A",
"relationship": "Parent",
"reference": "Luhm13",
"other_companion_names": "WISE J104915.57-531906.1A"
"other_companion_names": "Luhman 16A"
},
{
"companion_name": "WISE J104915.57-531906.1B",
"companion_name": "WISE J1049-5319B",
"relationship": "Parent",
"reference": "Luhm13",
"other_companion_names": "WISE J104915.57-531906.1B"
"other_companion_names": "Luhman 16B"
}
],
"Names": [
Expand Down
13 changes: 8 additions & 5 deletions data/source/wise_j104915.57-531906.1A.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"Sources": [
{
"source": "WISE J104915.57-531906.1A",
"source": "WISE J1049-5319A",
"ra": 162.329,
"dec": -53.3194,
"epoch": 2000.0,
Expand All @@ -17,13 +17,13 @@
"companion_name": "WISE J104915.57-531906.1",
"relationship": "Child",
"reference": "Luhm13",
"other_companion_names": "WISE J104915.57-531906.1"
"other_companion_names": null
},
{
"companion_name": "WISE J104915.57-531906.1B",
"companion_name": "WISE J1049-5319B",
"relationship": "Sibling",
"reference": "Luhm13",
"other_companion_names": "WISE J104915.57-531906.1B"
"other_companion_names": "Luhman 16B"
}
],
"ModeledParameters": [
Expand Down Expand Up @@ -68,7 +68,10 @@
"other_name": "NAME Luhman 16A"
},
{
"other_name": "WISE J104915.57-531906.1A"
"other_name": "WISE J1049-5319A"
},
{
"other_name": "Gaia DR2 5353626573555863424"
}
],
"Spectra": [
Expand Down
8 changes: 4 additions & 4 deletions data/source/wise_j104915.57-531906.1B.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"Sources": [
{
"source": "WISE J104915.57-531906.1B",
"source": "WISE J1049-5319B",
"ra": 162.329,
"dec": -53.3192,
"epoch": 2000.0,
Expand All @@ -20,10 +20,10 @@
"other_companion_names": "WISE J104915.57-531906.1"
},
{
"companion_name": "WISE J104915.57-531906.1A",
"companion_name": "WISE J1049-5319A",
"relationship": "Sibling",
"reference": "Luhm13",
"other_companion_names": "WISE J104915.57-531906.1A"
"other_companion_names": "Luhman 16A"
}
],
"ModeledParameters": [
Expand Down Expand Up @@ -68,7 +68,7 @@
"other_name": "NAME Luhman 16B"
},
{
"other_name": "WISE J104915.57-531906.1B"
"other_name": "WISE J1049-5319B"
}
],
"Spectra": [
Expand Down
11 changes: 6 additions & 5 deletions tests/scheduled_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,16 +93,17 @@ def test_source_simbad(db):
)
duplicate_count += 1

assert duplicate_count == 0, "Duplicate sources identified via Simbad queries"

# with open("not_in_simbad.txt", "w") as f:
# Write not_in_simbad list to file
# with open("tests/not_in_simbad_25Jul1.txt", "w") as f:
# f.write("\n".join(not_in_simbad))

assert duplicate_count == 0, "Duplicate sources identified via Simbad queries"

assert (
len(not_in_simbad) == 371
len(not_in_simbad) == 370
), f"Expecting {len(not_in_simbad)} sources not found in Simbad"

assert len(in_simbad) == 3227, "Sources found in Simbad"
assert len(in_simbad) == 3228, "Sources found in Simbad"
print(f"Found {len(in_simbad)} SIMPLE sources in Simbad")

assert len(not_in_simbad) + len(in_simbad) == len(
Expand Down
4 changes: 2 additions & 2 deletions tests/test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def test_sources(db):
assert n_sources == 3598, f"found {n_sources} sources"

n_names = db.query(db.Names).count()
assert n_names == 9172, f"found {n_names} names"
assert n_names == 9173, f"found {n_names} names"


@pytest.mark.parametrize(
Expand Down Expand Up @@ -98,7 +98,7 @@ def test_missions(db):
)
s = db.session.scalars(stm).all()
assert (
len(s) == 10
len(s) == 11
), f"found {len(s)} sources with Gaia designation that have no GAIA photometry"

# If Gaia photometry, Gaia designation should be in Names
Expand Down