remove spectra_utils #616
Merged
remove spectra_utils #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the ingest_spectra test suite, fully deleting tests/test_spectra_utils.py.
- Deletes all tests validating the
ingest_spectrumutility - Cleans up test artifacts related to spectra ingestion
Comments suppressed due to low confidence (1)
tests/test_spectra_utils.py:1
- [nitpick] Removing the entire
ingest_spectrumtest file will eliminate coverage for that functionality. Ensure the associated code is also removed or refactored and update CI/test configs accordingly to prevent coverage failures.
# temp_db and logger is defined in conftest.py
There was a problem hiding this comment.
Pull Request Overview
This PR removes all ingest_spectra scripts and their associated tests while updating the database schema to enforce non-null constraints and adjust unique constraints for the spectra data.
- Removed tests for ingest_spectra functionality.
- Updated simple/schema.yaml by setting "nullable: false" for the instrument mode and adding mode to the unique constraint columns.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_spectra_utils.py | Removed tests for ingest_spectrum functions, consistent with the removal of spectra_utils. |
| simple/schema.yaml | Updated the schema: set mode as non-null and added it to a composite constraint. |
Comments suppressed due to low confidence (1)
simple/schema.yaml:1042
- Ensure that existing data complies with the new non-null constraint for the instrument mode column or that a migration strategy is provided to update existing null values.
+ nullable: false
| columns: | ||
| - "#Spectra.source" | ||
| - "#Spectra.regime" | ||
| - "#Spectra.mode" |
There was a problem hiding this comment.
Verify that including '#Spectra.mode' in the composite unique constraint aligns with the intended data integrity rules and doesn't unintentionally restrict valid spectra entries.
canavarrete01
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all of the ingest_spectra scripts.