Skip to content

use ruapc-rdma-sys#35

Open
SF-Zhou wants to merge 2 commits intomainfrom
dev
Open

use ruapc-rdma-sys#35
SF-Zhou wants to merge 2 commits intomainfrom
dev

Conversation

@SF-Zhou
Copy link
Owner

@SF-Zhou SF-Zhou commented Feb 24, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 24, 2026 15:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates RDMA (Remote Direct Memory Access) verbs bindings from inline code to an external ruapc-rdma-sys crate. The migration removes locally-generated bindings, build scripts, and configuration code in favor of using a standalone system bindings crate.

Changes:

  • Replaces inline RDMA verbs bindings with dependency on ruapc-rdma-sys version 0.1.1
  • Removes verbs.rs, error.rs, devices.rs, config.rs modules and related infrastructure (build.rs, example)
  • Updates all imports from verbs:: prefix to direct imports (e.g., WRID, ibv_qp_cap)
  • Renames Devices::availables() to Devices::available() for better grammar
  • Maintains ACCESS_FLAGS constant in ruapc-rdma lib.rs instead of sys crate

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ruapc-rdma/Cargo.toml Adds ruapc-rdma-sys dependency, removes bindgen and build-dependencies
ruapc-rdma/build.rs Removed - bindings generation now handled by ruapc-rdma-sys
ruapc-rdma/src/lib.rs Re-exports all types from ruapc-rdma-sys, defines ACCESS_FLAGS constant
ruapc-rdma/src/verbs.rs Removed - types now provided by ruapc-rdma-sys
ruapc-rdma/src/error.rs Removed - Error types now provided by ruapc-rdma-sys
ruapc-rdma/src/devices.rs Removed - Device types now provided by ruapc-rdma-sys
ruapc-rdma/src/config.rs Removed - Config types no longer needed
ruapc-rdma/examples/ruapc_rdma_info.rs Removed - example no longer maintained
ruapc-rdma/src/queue_pair.rs Updates imports from verbs:: to crate::, updates documentation examples
ruapc-rdma/src/comp_queues.rs Updates imports and test to use Devices::available()
ruapc-rdma/src/comp_channel.rs Updates imports and test to use Devices::available()
ruapc-rdma/src/buf/rdma_buffer.rs Updates imports and uses crate::ACCESS_FLAGS
ruapc-rdma/src/buf/buffer_pool.rs Updates test to use Devices::available()
ruapc/src/sockets/rdma/rdma_socket_pool.rs Changes from verbs::ibv_qp_cap to ibv_qp_cap, Devices::available()
ruapc/src/sockets/rdma/rdma_socket.rs Changes from verbs::WRID to WRID
ruapc/src/sockets/rdma/event_loop.rs Updates imports from verbs:: to direct imports of RDMA types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.06%. Comparing base (09d1afa) to head (4b95075).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
ruapc/src/sockets/rdma/event_loop.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   85.76%   87.06%   +1.29%     
==========================================
  Files          36       33       -3     
  Lines        2909     2474     -435     
==========================================
- Hits         2495     2154     -341     
+ Misses        414      320      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants