Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates RDMA (Remote Direct Memory Access) verbs bindings from inline code to an external ruapc-rdma-sys crate. The migration removes locally-generated bindings, build scripts, and configuration code in favor of using a standalone system bindings crate.
Changes:
- Replaces inline RDMA verbs bindings with dependency on
ruapc-rdma-sysversion 0.1.1 - Removes
verbs.rs,error.rs,devices.rs,config.rsmodules and related infrastructure (build.rs, example) - Updates all imports from
verbs::prefix to direct imports (e.g.,WRID,ibv_qp_cap) - Renames
Devices::availables()toDevices::available()for better grammar - Maintains
ACCESS_FLAGSconstant in ruapc-rdma lib.rs instead of sys crate
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ruapc-rdma/Cargo.toml | Adds ruapc-rdma-sys dependency, removes bindgen and build-dependencies |
| ruapc-rdma/build.rs | Removed - bindings generation now handled by ruapc-rdma-sys |
| ruapc-rdma/src/lib.rs | Re-exports all types from ruapc-rdma-sys, defines ACCESS_FLAGS constant |
| ruapc-rdma/src/verbs.rs | Removed - types now provided by ruapc-rdma-sys |
| ruapc-rdma/src/error.rs | Removed - Error types now provided by ruapc-rdma-sys |
| ruapc-rdma/src/devices.rs | Removed - Device types now provided by ruapc-rdma-sys |
| ruapc-rdma/src/config.rs | Removed - Config types no longer needed |
| ruapc-rdma/examples/ruapc_rdma_info.rs | Removed - example no longer maintained |
| ruapc-rdma/src/queue_pair.rs | Updates imports from verbs:: to crate::, updates documentation examples |
| ruapc-rdma/src/comp_queues.rs | Updates imports and test to use Devices::available() |
| ruapc-rdma/src/comp_channel.rs | Updates imports and test to use Devices::available() |
| ruapc-rdma/src/buf/rdma_buffer.rs | Updates imports and uses crate::ACCESS_FLAGS |
| ruapc-rdma/src/buf/buffer_pool.rs | Updates test to use Devices::available() |
| ruapc/src/sockets/rdma/rdma_socket_pool.rs | Changes from verbs::ibv_qp_cap to ibv_qp_cap, Devices::available() |
| ruapc/src/sockets/rdma/rdma_socket.rs | Changes from verbs::WRID to WRID |
| ruapc/src/sockets/rdma/event_loop.rs | Updates imports from verbs:: to direct imports of RDMA types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 85.76% 87.06% +1.29%
==========================================
Files 36 33 -3
Lines 2909 2474 -435
==========================================
- Hits 2495 2154 -341
+ Misses 414 320 -94 ☔ View full report in Codecov by Sentry. |
No description provided.