Closed
Conversation
- HMAC_SECRET을 선택적 변수로 변경하여 .env 누락 시 서버가 강제 종료되는 문제 해결 - API 요청 시 실제 해싱이 일어날 때만 명시적 에러를 발생시키도록 보장
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
개요
변경 사항
예상 코드 리뷰 노력🎯 1 (Trivial) | ⏱️ ~5 분 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 개요
관련 이슈: [Feat] Discord 웹훅 로그 상세화 — 로드맵 생성/수정 파이프라인 내부 추적 #69 관련 후속 조치)
2. 작업 내용
app/core/config.py의Settings클래스에서HMAC_SECRET을 필수 필드(str)에서 선택 필드(str | None = None)로 변경했습니다..env파일에 해당 키가 누락되어도 앱 부팅 과정에서 크래시(Crash)가 발생하는 문제를 방지합니다.process_chat_request,google_places_service)에 값이 없을 때만 명시적으로 예외(ValueError)를 던지도록 하여 보안 상의요구사항("fail loudly if missing")은 그대로 유지했습니다.
3. AI 활용 및 검증
AI가 생성한 코드 포함
100% 직접 작성
검증 방법:
HMAC_SECRET이.env에 없는 상태로 서버가 정상적으로 부팅되는지 확인.pytest tests/를 통해 관련 유닛 테스트들이 모두 정상 통과함을 확인.4. 스크린샷 (선택)
(생략)
Summary by CodeRabbit
변경 사항