Tasks 1-5 #1
Open
Tasks 1-5 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olenaniemova
commented
Aug 18, 2023
Comment on lines
+8
to
+11
| execute <<-SQL | ||
| INSERT INTO user_logins (user_id, login_at) | ||
| SELECT id, last_login_at FROM users; | ||
| SQL |
Collaborator
Author
There was a problem hiding this comment.
I know, it is not the best solution to put raw SQL in the migration to migrate data from one table to another. But it works in this small project.
For real projects which have a big codebase and database, in such cases, I would use a data-migrate gem or rake task to create separate migration for data. The development should look like this:
- Create migration for the new table, create migration for data, change code to save data into the new table
- Test, release to prod, and check that all work well
- Create migration to remove the old column
- Test, release changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task 1: Display User Info on Member Dashboard
Currently, after signing in, the User will see a "dashboard" screen. Update that dashboard so it shows their email, created at, and updated at instead of "...".
Task 2: Store and Display All Login Timestamps
Currently, the member dashboard only shows the time of their most recent login. Make the necessary changes to the database, models, controllers, and views so we can store and display when every login happens for a user.
Task 3: Product Detail Page + Categories
Display a list of all the categories each product belongs to, and link to them.
Task 4: "Favorite" a Product
If the current user is signed in, show a heart icon which the user can click to "heart" the product, and click again to remove the product from their favorites.
On the "Members Dashboard" view, add a list of links to their favorite products.
Task 5: Only show "is_active=true" Products
On the Category page, only show "active" products.
If a product with "is_active=false" is requested, return a 404 response.
Remove "is_active=false" products from the Members Dashboard "favorite products" list.
Results
Product page (added categories, add to favorite)
404 page when the product is not active
